Replace Task.WhenAny timeout pattern with Task.WaitAsync#1253
Closed
Copilot wants to merge 2 commits intohalter73/test-client-dispose-hangfrom
Closed
Replace Task.WhenAny timeout pattern with Task.WaitAsync#1253Copilot wants to merge 2 commits intohalter73/test-client-dispose-hangfrom
Copilot wants to merge 2 commits intohalter73/test-client-dispose-hangfrom
Conversation
Co-authored-by: halter73 <54385+halter73@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update PR to use Task.WaitAsync as requested in review feedback
Replace Task.WhenAny timeout pattern with Task.WaitAsync
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors dispose timeout tests to use
Task.WaitAsyncinstead ofTask.WhenAnywithTask.Delay, per review feedback on #1252.Changes
StreamableHttpClientConformanceTestsandMapMcpStreamableHttpTestsTask.WaitAsyncthrowsTimeoutExceptionautomaticallyBefore
After
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.